fix(tui): resolve /compact alias collision between compress alias and TUI display toggle (#57070) - #907
Open
hashbender wants to merge 1 commit into
Open
fix(tui): resolve /compact alias collision between compress alias and TUI display toggle (#57070)#907hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
… TUI display toggle (NousResearch#57070)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR NousResearch#57029 added
"compact"as an alias for thecompresscommand (CommandDef("compress", ..., aliases=("compact",))). This collided with the pre-existing/compactTUI display toggle in_TUI_EXTRA, causingcommands.catalogRPC to return/compacttwice with two different meanings:/compress("Compress conversation context")Impact: Clients that treat
pairsentries andcanonaliases as mutually exclusive crash on startup (e.g. fathah/hermes-desktop#802).Changes
/compactTUI display toggle to/compact-uiin_TUI_EXTRAcommands.cataloghandler: skip_TUI_EXTRAentries whose name already appears as a registered command or alias incanonsettings.toggleandsettings.gethandlers accept both"compact"and"compact-ui"keys/compact-uiFixes NousResearch#57070
Mirror-of: NousResearch#57131
NousResearch#57131